[smartmontools-support] drivedb: Too broad pattern for xerrorlba application

[astian]

On 6 May 2026 12:10 +0200, Christian Franke wrote:
[...]
>> Commit e4f0953ec (svn 4802, trac ticket 1094) added the -F option to
>> this entire family of disks but apparently not all firmware versions
>> have this bug.
>>
>> I added this override and it worked fine:
>>
>>    { "Seagate Momentus 5400.6",
>>      "ST9500325AS",
>>      "0001SDM1", "", ""
>>    },
>>
>> But maybe the existing buggy entry should be restricted to FW 0002SDM1,
>> and/or this new one for 0001SDM1 should be extended to other models, I
>> don't know.
>
> Yes, this makes sense. Unfortunately there are only very few samples
> with non-empty error logs and vendors typically do not document such bugs.
>
> For such drive database change requests, please follow the instructions
> from:
> https://www.smartmontools.org/wiki/FAQ#MyATASATAdriveisnotinthesmartctlsmartddatabase

Unfortunately I already returned the disk to its owner, so I can't take
a fresh -x dump.  I still have a log dump which I took while working on
it but it was taken after I already applied my drivedb override.  I'll
post that and hopefully it will be good enough.

>> (Btw, looks like the git conversion messed up the svn commit messages,
>> bunching them up into a single line. ...
>
> This is not correct. The custom 'svn2git' conversion preserved the
> newlines, see 'git log'.
> https://sourceforge.net/p/smartmontools/code/4802
> https://github.com/smartmontools/smartmontools/commit/e4f0953ec
> https://github.com/smartmontools/smartmontools/commit/e4f0953ec.patch
> The above shows that the problem only occurs with 'git format-patch'.
> This also happens if the standard svn to git conversion ('git svn
> fetch') was used.

Ah, I see.  It's because many SVN messages don't conform to the git
"title empty-line body" convention.  In my case, I got confused by the
rendering done by fugitive (Vim plugin), using the %s and %b formatting
specifiers (instead of %B, the unformatted message).  (It turns out
fugitive fixed this long ago, but there hasn't been a release in ~4
years.)  Surely, git format-patch is doing similarly.

Glad to be wrong about that.