[smartmontools-support] drivedb: Too broad pattern for xerrorlba application

[Christian Franke]

Hi,

thanks for your report.

On Fri, 24 Apr 2026 14:41:48 +0000, astian via Smartmontools-support wrote:

> ...
> I got my hands on an old SATA2 spinning disk:
>
>    Model Family:     Seagate Momentus 5400.6
>    Device Model:     ST9500325AS
>    [...]
>    Firmware Version: 0001SDM1
> ...
>
> It matches this drivedb entry:
>
>    { "Seagate Momentus 5400.6",
>      "ST9(80313|160(301|314)|(12|25)0315|250317|(320|500)325|500327|640320)ASG?",
>      "", "",
>      "-F xerrorlba" // ST9500325AS/0002SDM1 (ticket #1094)
>    },
>
> However this "xerrorlba" "fix" actually breaks the LBA interpretation:
>
>    After command completion occurred, registers were:
>    ER -- ST COUNT  LBA_48  LH LM LL DV DC
>    -- -- -- == -- == == == -- -- -- -- --
>    40 -- 51 00 00 00 54 00 a3 30 af 00 00  Error: UNC at LBA = 0x5400a330af = 360787947695
>
> That sector does not exist.  Using "-P ignore" fixes it:
>
>    After command completion occurred, registers were:
>    ER -- ST COUNT  LBA_48  LH LM LL DV DC
>    -- -- -- == -- == == == -- -- -- -- --
>    40 -- 51 00 00 00 00 30 54 a3 af 00 00  Error: UNC at LBA = 0x3054a3af = 810853295
>
> Commit e4f0953ec (svn 4802, trac ticket 1094) added the -F option to
> this entire family of disks but apparently not all firmware versions
> have this bug.
>
> I added this override and it worked fine:
>
>    { "Seagate Momentus 5400.6",
>      "ST9500325AS",
>      "0001SDM1", "", ""
>    },
>
> But maybe the existing buggy entry should be restricted to FW 0002SDM1,
> and/or this new one for 0001SDM1 should be extended to other models, I
> don't know.

Yes, this makes sense. Unfortunately there are only very few samples 
with non-empty error logs and vendors typically do not document such bugs.

For such drive database change requests, please follow the instructions 
from:
https://www.smartmontools.org/wiki/FAQ#MyATASATAdriveisnotinthesmartctlsmartddatabase


> (Btw, looks like the git conversion messed up the svn commit messages,
> bunching them up into a single line. ...

This is not correct. The custom 'svn2git' conversion preserved the 
newlines, see 'git log'.
https://sourceforge.net/p/smartmontools/code/4802
https://github.com/smartmontools/smartmontools/commit/e4f0953ec
https://github.com/smartmontools/smartmontools/commit/e4f0953ec.patch
The above shows that the problem only occurs with 'git format-patch'.
This also happens if the standard svn to git conversion ('git svn 
fetch') was used.


> ... Also, the conventional HEAD is
> master (...).)

The master branch is still present but has been retired, see "Moved to 
GitHub" at:
https://github.com/smartmontools/smartmontools/blob/main/doc/CHANGELOG.md

-- 
Regards,
Christian