[smartmontools-support] macOS NVMe support is documented!

[Harry Mallon]

Hi Christian,

I attach two patches. To be honest I wasn't quite sure what to do with the 'old' code. There is an argument for just putting the whole header into the smartmontools tree (like linux_nvme_ioctl.h does). For now I have done small updates to the existing code and ifdeffed to allow building against the new header. It builds in both configurations for me and I can see some info from my SSD, but I wouldn't consider it fully tested.

Harry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-os_darwin-Cleanup-trailing-whitespace.patch
Type: application/octet-stream
Size: 6460 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/smartmontools-support/attachments/20200616/83e23e93/attachment-0002.obj>
-------------- next part --------------

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-os_darwin-Use-documented-NVMeSMARTLibExternal.h.patch
Type: application/octet-stream
Size: 4483 bytes
Desc: not available
URL: <https://listi.jpberlin.de/pipermail/smartmontools-support/attachments/20200616/83e23e93/attachment-0003.obj>
-------------- next part --------------


> On 16 Jun 2020, at 12:05, Christian Franke <Christian.Franke at t-online.de> wrote:
> 
> Harry Mallon wrote:
>> Hi,
>> 
>> The header is available in the latest XCode (I am on 11.5), they don't seem to have put it in the online docs. At this path for me. I can update the code and send a patch if it would be useful?
>> 
>> /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/IOKit.framework/Versions/A/Headers/storage/nvme/NVMeSMARTLibExternal.h
>> 
> 
> Yes, please.
> 
> Please make sure to provide backward compatibility (AC_CHECK_HEADER...) for builds without this header. At least our docker-build image used for CircleCI builds does not yet include this header.
> 
> Thanks,
> Christian
>