[smartmontools-support] [PATCH] RFC: libata: Add hwmon support for SMART temperature sensors

[Guenter Roeck]

On Tue, Aug 14, 2018 at 11:03:03PM +0200, Linus Walleij wrote:
> On Mon, Aug 13, 2018 at 12:31 AM Guenter Roeck <linux at roeck-us.net> wrote:
> > On 08/09/2018 09:15 PM, Guenter Roeck wrote:
> > > On 08/09/2018 03:24 PM, Linus Walleij wrote:
> 
> > >> +        if (id == SMART_TEMP_PROP_194)
> > >> +            break;
> >
> > 231 also seems to report the temperature if available, as does 190.
> 
> They have the same temperature format(s) but AFAICT these
> have specific meanings:
> smartmontools has a drive database that tells the story.
> 
> 190 is the Air flow temperature
> 231 reports temperature on some drives but on others this is the
>    "SSD life left"
> 
> To avoid erroneous interpretation I kept with just 194.
> 
Makes sense.

> > Not sure if 190 is worth it, though - Samsung SSD 840 PRO Series supports
> > it but reports a static value of 28. And it seems to be either as
> > degrees C or as 100 - degrees C, depending on the drive manufacturer,
> > which makes it quite unreliable.
> 
> I guess we could add more heuristics if we want. Maybe not
> as the first step.
> 
Agreed.

Thanks,
Guenter