[PATCH] Unhardcode /bin/bash

[Brian Callahan]

On 08/16/14 08:47, Thorsten Wißmann wrote:
> On Tue, Aug 12, 2014 at 07:55:50AM -0400, Brian Callahan wrote:
>> As the subject line says, this unhardcodes /bin/bash to /usr/bin/env bash.
>> This eases packing on the BSDs, and probably other systems, that do not put
>> bash in /bin.
>> This is what I have to do as the OpenBSD port maintainer of hlwm to get hlwm
>> to work.
> The idea sounds fine to me, so thanks for the suggestion!
>
>> Generated from
>> perl -pi -e "s,^#!/bin/bash,#!/usr/bin/env bash,g" `grep -Rl /bin/bash *`
>> from the top of the hlwm tree.
> Thanks for the regex, it helped me a lot finding some problems in your
> patch (see below). (BTW I needed to single-quote the regexp because of
> the '!').
>
> There are many problems with the format of your patch, which seem to be
> caused by your user-agent, Thunderbird:
>
>> @@ -154,7 +154,7 @@ Add a rule for the clients pid, before the client
>> appears. This script
>>   creates two xterms with different behaviours:
> Here, your user-agent wrapped the long line, so the patch became
> invalid. Furthermore all trailing spaces were missing in your patch (and
> there were some more problems and it took some time to make it apply. I
> was able to get the problem because you gave me the regexp).
>
> It is now merged as:
>
> * b1fe138 Unhardcode /bin/bash
>
> To avoid the above patch-problem in the future, I suggest one of the
> following solutions (with decreasing priority):
>
>    - Attach the patch generated by git-format-patch to your mail (instead
>      of inlining it)
>    - Get familiar with spaces/newlines and then disable the
>      auto-line-wrapping feature of Thunderbird (which also causes
>      problems with the Enigmail-Plugin when signing mails)
>    - Send patches using git-send-email (Used by many people, IMO not
>      worth the effort of setting up a local MTA)
>
> Cheers,
> Thorsten
>

Thanks. I'll attach future patches.

(You're much nicer than we are - I'd reject out of hand any patch that 
didn't apply cleanly. :) )

~Brian